flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #10029: [FLINK-14553][runtime] Respect non-blocking output in StreamTask#processInput
Date Thu, 31 Oct 2019 04:33:02 GMT
zhijiangW commented on a change in pull request #10029:  [FLINK-14553][runtime] Respect non-blocking
output in StreamTask#processInput
URL: https://github.com/apache/flink/pull/10029#discussion_r340956723
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
 ##########
 @@ -35,23 +35,23 @@
  * In this case {@link ResultPartitionWriter#fail(Throwable)} still needs to be called afterwards
to fully release
  * all resources associated the the partition and propagate failure cause to the consumer
if possible.
  */
-public interface ResultPartitionWriter extends AutoCloseable {
+public abstract class ResultPartitionWriter implements AutoCloseable, AvailabilityProvider
{
 
 Review comment:
   Yes, it is no issue here, and my memory was wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message