flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] TisonKun opened a new pull request #10056: [FLINK-14565][metric] Shut down SystemResourcesCounter on Metric closed to prevent thread leak
Date Thu, 31 Oct 2019 06:00:48 GMT
TisonKun opened a new pull request #10056: [FLINK-14565][metric] Shut down SystemResourcesCounter
on Metric closed to prevent thread leak
URL: https://github.com/apache/flink/pull/10056
 
 
   ## What is the purpose of the change
   
   Solve potentially thread leak described in [FLINK-14565](https://issues.apache.org/jira/browse/FLINK-14565).
   
   ## Brief change log
   
   When create `SystemResourcesCounter`, hold the ref in (JM|TM)MetricGroup and on closed
shut down the `SystemResourcesCounter` thread.
   
   
   ## Verifying this change
   
   Straightforward and manually verify previous leak threads disappear in case.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message