flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] docete edited a comment on issue #10035: [FLINK-14080][table-planner-blink] Introduce Timestamp as internal representation of TIMESTAMP_WITHOUT_TIME_ZONE
Date Thu, 31 Oct 2019 09:08:56 GMT
docete edited a comment on issue #10035: [FLINK-14080][table-planner-blink] Introduce Timestamp
as internal representation of TIMESTAMP_WITHOUT_TIME_ZONE
URL: https://github.com/apache/flink/pull/10035#issuecomment-548245095
 
 
   @wuchong
   1. Adding new interface for BaseRow is another problem
   2. We use `java.sql.Timestamp` as long in all builtin time functions, codegen, etc. we
need put the milli part and integral second together for better performance.
   3. `LocalDateTime`/`Instant` have different meaning in Java, it's weird to use `Instant`
as the internal representation of `LocalDateTime`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message