flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] liyafan82 commented on a change in pull request #8194: [FLINK-12216][Runtime]Respect the number of bytes from input parameters in HybridMemorySegment
Date Thu, 31 Oct 2019 09:39:28 GMT
liyafan82 commented on a change in pull request #8194: [FLINK-12216][Runtime]Respect the number
of bytes from input parameters in HybridMemorySegment
URL: https://github.com/apache/flink/pull/8194#discussion_r341036537
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/core/memory/MemorySegmentTestBase.java
 ##########
 @@ -1955,11 +1955,6 @@ private void testByteBufferGet(boolean directBuffer) {
 		assertArrayEquals(bytes, result);
 	}
 
-	@Test(expected = ReadOnlyBufferException.class)
-	public void testHeapByteBufferGetReadOnly() {
 
 Review comment:
   Sorry, there is a mistake in my previous comment. 
   The test in HeapMemorySegmentTest throws ReadOnlyBufferException. 
   I have revised the code accordingly. Please take a look. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message