flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jark Wu (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (FLINK-13382) Port DecimalITCase to unit tests
Date Sun, 06 Oct 2019 01:58:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jark Wu resolved FLINK-13382.
-----------------------------
    Resolution: Fixed

1.10.0: a110cec19c5770fadfc460a8ef4d351a3593190a

> Port DecimalITCase to unit tests
> --------------------------------
>
>                 Key: FLINK-13382
>                 URL: https://issues.apache.org/jira/browse/FLINK-13382
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Jark Wu
>            Assignee: Leonard Xu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are 81 query tests in {{org.apache.flink.table.runtime.batch.sql.DecimalITCase}}
and 67 query tests in {{org.apache.flink.table.runtime.batch.table.DecimalITCase}}. 
> Note that each query will be executed on a MiniCluster which will consume a lot of testing
time. However, decimals can be tested as unit tests similar to other Scalar functions tests.
> So I would suggest to move Decimal IT cases to unit tests {{org.apache.flink.table.expressions.DecimalTypeTest}}.
This should save much testing time. 
> In the meanwhile, IMO, this is not required by 1.9 release. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message