flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] danny0405 commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark information in TableSchema
Date Fri, 01 Nov 2019 02:19:43 GMT
danny0405 commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark
information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r341427377
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
 ##########
 @@ -157,11 +181,11 @@ public TableSchema copy() {
 	/**
 	 * Returns the specified data type for the given field name.
 	 *
-	 * @param fieldName the name of the field
+	 * @param fieldName the name of the field, the field name can be a qualified name, e.g.
"f0.q1"
 	 */
 	public Optional<DataType> getFieldDataType(String fieldName) {
 
 Review comment:
   "f0.q1" is a little confusing, maybe "record_name.field_name" ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message