flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] danny0405 commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark information in TableSchema
Date Fri, 01 Nov 2019 02:19:43 GMT
danny0405 commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark
information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r341428236
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/WatermarkSpec.java
 ##########
 @@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.table.expressions.ResolvedExpression;
+
+import java.util.Objects;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * Watermark metadata defined in {@link TableSchema}. It mainly contains two parts,
+ * 1) the rowtime attribute.
+ * 2) the watermark generation strategy.
+ */
+public class WatermarkSpec {
+
+	private final String rowtimeAttribute;
+
+	private final ResolvedExpression watermarkStrategy;
+
+	public WatermarkSpec(String rowtimeAttribute, ResolvedExpression watermarkStrategy) {
+		this.rowtimeAttribute = checkNotNull(rowtimeAttribute);
+		this.watermarkStrategy = checkNotNull(watermarkStrategy);
+	}
+
+	/**
+	 * Returns the name of rowtime attribute, it can be a nested field using dot separator.
+	 * The referenced attribute must be present in the {@link TableSchema} and of
+	 * type {@link DataTypes#TIMESTAMP(int)}.
+	 */
+	public String getRowtimeAttribute() {
 
 Review comment:
   `DataTypes#TIMESTAMP(int)` is just a tool method and not a "type".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message