flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] danny0405 commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark information in TableSchema
Date Fri, 01 Nov 2019 02:19:43 GMT
danny0405 commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark
information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r341427986
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
 ##########
 @@ -343,13 +396,30 @@ public Builder field(String name, TypeInformation<?> typeInfo)
{
 			return field(name, fromLegacyInfoToDataType(typeInfo));
 		}
 
+		/**
+		 * Specifies the previously defined field as an event-time attribute and specifies the
watermark strategy.
+		 *
+		 * @param rowtimeAttribute the field name as a rowtime attribute, can be a nested field
using dot separator.
+		 * @param watermarkStrategy the watermark strategy expression
+		 */
+		public Builder watermark(String rowtimeAttribute, ResolvedExpression watermarkStrategy)
{
 
 Review comment:
   If we agree that `Expression` would make the interface more uniform(can be used by table
api), can we use just `Expression` as the argument specification ? Then we can eliminate use
to use the `SqlExpression` for current implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message