flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lirui-apache commented on a change in pull request #10062: [FLINK-14588][hive] Support Hive version 1.0.0 and 1.0.1
Date Fri, 01 Nov 2019 02:33:50 GMT
lirui-apache commented on a change in pull request #10062: [FLINK-14588][hive] Support Hive
version 1.0.0 and 1.0.1
URL: https://github.com/apache/flink/pull/10062#discussion_r341432718
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
 ##########
 @@ -1099,7 +1092,7 @@ private static Function instantiateHiveFunction(ObjectPath functionPath,
Catalog
 
 		return new Function(
 			// due to https://issues.apache.org/jira/browse/HIVE-22053, we have to normalize function
name ourselves
-			HiveStringUtils.normalizeIdentifier(functionPath.getObjectName()),
+			functionPath.getObjectName().trim().toLowerCase(),
 
 Review comment:
   Because 1.0.x doesn't have that util method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message