flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] xuefuz commented on a change in pull request #10054: [FLINK-14221][table] support drop temp system functions and temp catalog functions
Date Fri, 01 Nov 2019 02:44:04 GMT
xuefuz commented on a change in pull request #10054: [FLINK-14221][table] support drop temp
system functions and temp catalog functions
URL: https://github.com/apache/flink/pull/10054#discussion_r341399463
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
 ##########
 @@ -193,6 +194,42 @@ public void registerTempCatalogScalarFunction(ObjectIdentifier oi, ScalarFunctio
 		);
 	}
 
+	/**
+	 * Drops a temporary system function.
 
 Review comment:
   Drops => Drop, following the same comment style. Same below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message