flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #10017: [FLINK-14019][python] add support for managing environment and dependencies of Python UDF in Flink Python API
Date Fri, 01 Nov 2019 03:48:40 GMT
hequn8128 commented on a change in pull request #10017: [FLINK-14019][python] add support for
managing environment and dependencies of Python UDF in Flink Python API
URL: https://github.com/apache/flink/pull/10017#discussion_r341437522
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/python/PythonDependencyManager.java
 ##########
 @@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.python;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.cache.DistributedCache;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * This class is used to parse the information of python dependency and environment management
+ * stored in GlobalJobParameters.
+ * The parse result will be used to create PythonEnvironmentManager.
+ */
+@Internal
+public class PythonDependencyManager {
+
+	public static final String PYTHON_FILE_MAP = "PYTHON_FILE_MAP";
+	public static final String PYTHON_REQUIREMENTS = "PYTHON_REQUIREMENTS";
+	public static final String PYTHON_REQUIREMENTS_DIR = "PYTHON_REQUIREMENTS_DIR";
+	public static final String PYTHON_ARCHIVES_MAP = "PYTHON_ARCHIVES_MAP";
+	public static final String PYTHON_EXEC = "PYTHON_EXEC";
+
+	private Map<String, String> filesInPythonPath;
+	private String requirementsFilePath;
+	private String requirementsDirPath;
+	private String pythonExec;
+	private Map<String, String> archives;
 
 Review comment:
   Use @Nullable annotation for these class members.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message