flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] docete commented on a change in pull request #10022: [FLINK-14135][orc] Introduce OrcColumnarRowInputFormat
Date Fri, 01 Nov 2019 06:03:02 GMT
docete commented on a change in pull request #10022: [FLINK-14135][orc] Introduce OrcColumnarRowInputFormat
URL: https://github.com/apache/flink/pull/10022#discussion_r341459203

 File path: flink-connectors/flink-orc/src/test/java/org/apache/flink/orc/OrcColumnarRowInputFormatTest.java
 @@ -0,0 +1,184 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.orc;
+import org.apache.flink.core.fs.FileInputSplit;
+import org.apache.flink.table.dataformat.ColumnarRow;
+import org.apache.flink.util.InstantiationUtil;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.ql.io.sarg.PredicateLeaf;
+import org.junit.After;
+import org.junit.Test;
+import java.io.IOException;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+ * Unit tests for {@link OrcColumnarRowInputFormat}.
+ */
+public class OrcColumnarRowInputFormatTest {
 Review comment:
   It seems we copy few test from `OrcRowInputFormatTest`.
   Could you test more case for `ColumnarRowInputFormat`?
   Or can you refactor the tests and let `OrcRowInputFormatTest` and `OrcColumnarRowInputFormatTest`
reuse some code?

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message