flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] docete commented on a change in pull request #10022: [FLINK-14135][orc] Introduce OrcColumnarRowInputFormat
Date Fri, 01 Nov 2019 06:03:02 GMT
docete commented on a change in pull request #10022: [FLINK-14135][orc] Introduce OrcColumnarRowInputFormat
URL: https://github.com/apache/flink/pull/10022#discussion_r340393798
 
 

 ##########
 File path: flink-connectors/flink-orc/pom.xml
 ##########
 @@ -62,6 +62,13 @@ under the License.
 			<scope>provided</scope>
 			<optional>true</optional>
 		</dependency>
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
 
 Review comment:
   Why we need this dependency? I think the connector should not dependency the planner.
   We can depend on the flink-table-runtime-blink module for the data format classes.
   But in the long run, the data format classes should move to flink-table-common module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message