flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] godfreyhe opened a new pull request #10158: [FLINK-14694] [table-planner-blink] Most tests from package o.a.f.table.planner.functions.aggfunctions are not executed during mvn test and fix BinaryGeneric comparison failure
Date Tue, 12 Nov 2019 08:26:10 GMT
godfreyhe opened a new pull request #10158: [FLINK-14694] [table-planner-blink] Most tests
from package o.a.f.table.planner.functions.aggfunctions are not executed during mvn test and
fix BinaryGeneric comparison failure
URL: https://github.com/apache/flink/pull/10158
 
 
   
   
   ## What is the purpose of the change
   
   *Most tests from package o.a.f.table.planner.functions.aggfunctions are not executed during
mvn test because those test case classed are abstract class and will be ignored when running
`mvn test`. In [FLINK-13702](https://issues.apache.org/jira/browse/FLINK-14694), `BinaryGeneric`
can't be compared directly, so those failures are also ignored. This pr aims to fix both.
The first one's solution is introducing [Enclosed](https://junit.org/junit4/javadoc/4.12/org/junit/experimental/runners/Enclosed.html)
runner, and moving the abstract class as an inner class, and making sure the outer class is
a non-abstract class. The second one's solution is verifying `BinaryGeneric` using `BinaryGenericAsserter.equivalent`
(should also consider that `BinaryGeneric` is in `GenericRow`) *
   
   ## Brief change log
   
     - *introducing `Enclosed` runner and make sure the outer class is a non-abstract class*
     - *comparing `BinaryGeneric` using `BinaryGenericAsserter.equivalent` *
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message