flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski opened a new pull request #10218: [hotfix][network] Reduce the synchronisation overhead in CreditBasedSequenceNumberingViewReader
Date Fri, 15 Nov 2019 11:24:37 GMT
pnowojski opened a new pull request #10218: [hotfix][network] Reduce the synchronisation overhead
in CreditBasedSequenceNumberingViewReader
URL: https://github.com/apache/flink/pull/10218
 
 
   Previously CreditBasedSequenceNumberingViewReader#isAvailable() was synchronising twice
on the lock subpartitionView if there are no credits: first in subpartitionView.isAvailable()
and second in subpartitionView.nextBufferIsEvent(). The first one `subpartitionView.isAvailable()`
check is redundant (always true) if `subpartitionView.nextBufferIsEvent()` is also true so
it should be safe to simplify the code.
   
   ## Verifying this change
   
   This change is already covered by existing network stack tests and most of the ITCases/e2e
tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message