flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #10079: [FLINK-14594] Fix matching logics of ResourceSpec/ResourceProfile/Resource considering double values
Date Fri, 15 Nov 2019 12:17:48 GMT
zentol commented on a change in pull request #10079: [FLINK-14594] Fix matching logics of ResourceSpec/ResourceProfile/Resource
considering double values
URL: https://github.com/apache/flink/pull/10079#discussion_r346789381
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/api/common/operators/ResourceSpecTest.java
 ##########
 @@ -35,23 +35,7 @@
 public class ResourceSpecTest extends TestLogger {
 
 	@Test
-	public void testIsValid() throws Exception {
-		ResourceSpec rs = ResourceSpec.newBuilder(1.0, 100).build();
-		assertTrue(rs.isValid());
-
-		rs = ResourceSpec.newBuilder(1.0, 100).
-				setGPUResource(1).
-				build();
-		assertTrue(rs.isValid());
-
-		rs = ResourceSpec.newBuilder(1.0, 100).
-				setGPUResource(-1).
-				build();
-		assertFalse(rs.isValid());
-	}
-
-	@Test
-	public void testLessThanOrEqual() throws Exception {
+	public void testLessThanOrEqual_BothSpecified() {
 
 Review comment:
   we don't use underscores in method names

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message