flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #10079: [FLINK-14594] Fix matching logics of ResourceSpec/ResourceProfile/Resource considering double values
Date Fri, 15 Nov 2019 12:17:48 GMT
zentol commented on a change in pull request #10079: [FLINK-14594] Fix matching logics of ResourceSpec/ResourceProfile/Resource
considering double values
URL: https://github.com/apache/flink/pull/10079#discussion_r346788253
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/resources/Resource.java
 ##########
 @@ -33,71 +34,34 @@
 
 	private static final long serialVersionUID = 1L;
 
-	/**
-	 * Enum defining how resources are aggregated.
-	 */
-	public enum ResourceAggregateType {
-		/**
-		 * Denotes keeping the sum of the values with same name when merging two resource specs
for operator chaining.
-		 */
-		AGGREGATE_TYPE_SUM,
-
-		/**
-		 * Denotes keeping the max of the values with same name when merging two resource specs
for operator chaining.
-		 */
-		AGGREGATE_TYPE_MAX
-	}
-
 	private final String name;
 
-	private final double value;
+	private final BigDecimal value;
 
-	private final ResourceAggregateType resourceAggregateType;
+	protected Resource(String name, double value) {
+		this(name, BigDecimal.valueOf(value));
+	}
 
-	protected Resource(String name, double value, ResourceAggregateType type) {
+	protected Resource(String name, BigDecimal value) {
 
 Review comment:
   maybe check that this is greater than 0?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message