flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] GJL commented on a change in pull request #10152: [FLINK-14466][runtime] Let YarnJobClusterEntrypoint use user code class loader
Date Fri, 15 Nov 2019 12:20:24 GMT
GJL commented on a change in pull request #10152: [FLINK-14466][runtime] Let YarnJobClusterEntrypoint
use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r346797730
 
 

 ##########
 File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
 ##########
 @@ -126,7 +130,18 @@ public void testCopyFromLocalRecursiveWithoutScheme() throws Exception
{
 		final FileSystem targetFileSystem = hdfsRootPath.getFileSystem(hadoopConfig);
 		final Path targetDir = targetFileSystem.getWorkingDirectory();
 
-		testCopyFromLocalRecursive(targetFileSystem, targetDir, tempFolder, false);
+		testCopyFromLocalRecursive(targetFileSystem, targetDir, LOCAL_RESOURCE_DIRECTORY, tempFolder,
false);
+	}
+
+	/**
+	 * Verifies that a single file is properly copied.
+	 */
+	@Test
+	public void testCopyAFileFromLocal() throws IOException, URISyntaxException, InterruptedException
{
 
 Review comment:
   I tried to refactor this but it is not easily possible. One of the reasons is that we cannot
easily determine the working directory because we statically add `/.flink/appid` to the target
path. I am actually ok with leaving this test. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message