flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] KurtYoung commented on a change in pull request #10196: [FLINK-14789] [table-planner-blink] extends max/min type in ColumnStats from Number to Comparable
Date Fri, 15 Nov 2019 14:13:00 GMT
KurtYoung commented on a change in pull request #10196: [FLINK-14789] [table-planner-blink]
extends max/min type in ColumnStats from Number to Comparable
URL: https://github.com/apache/flink/pull/10196#discussion_r346838659
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/plan/stats/ColumnStats.java
 ##########
 @@ -50,28 +50,72 @@
 	private final Integer maxLen;
 
 	/**
-	 * max value of column values.
+	 * Deprecated because not well supported comparable type,
+	 * e.g. {@link java.util.Date}, {@link java.sql.Timestamp}.
 	 */
-	private final Number max;
+	@Deprecated
+	private final Number maxValue;
 
 	/**
-	 * min value of column values.
+	 * max value of column values, null if the value is not comparable.
 
 Review comment:
   `null if the value is not comparable`? 
   I thought null means we don't have such information. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message