flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dawidwys commented on a change in pull request #10216: [FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions
Date Fri, 15 Nov 2019 14:18:42 GMT
dawidwys commented on a change in pull request #10216:  [FLINK-14750][configuration] Migrate
duration and memory size ConfigOptions in RestartStrategyOptions
URL: https://github.com/apache/flink/pull/10216#discussion_r346842816
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
 ##########
 @@ -162,6 +162,14 @@ public boolean equals(Object obj) {
 			}
 		}
 
+		@Override
+		public String toString() {
+			return "FixedDelayRestartStrategyConfiguration{" +
 
 Review comment:
   You are right. I should've added it to all classes. I added it for debugging. 
   
   I added a common implementation to the base class that reuses the description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message