flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #10216: [FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions
Date Fri, 15 Nov 2019 15:05:54 GMT
zentol commented on a change in pull request #10216:  [FLINK-14750][configuration] Migrate
duration and memory size ConfigOptions in RestartStrategyOptions
URL: https://github.com/apache/flink/pull/10216#discussion_r346866339
 
 

 ##########
 File path: docs/_includes/generated/failure_rate_restart_strategy_configuration.html
 ##########
 @@ -10,14 +10,14 @@
     <tbody>
         <tr>
             <td><h5>restart-strategy.failure-rate.delay</h5></td>
-            <td style="word-wrap: break-word;">"1 s"</td>
-            <td>String</td>
+            <td style="word-wrap: break-word;">1000ms</td>
+            <td>Duration</td>
             <td>Delay between two consecutive restart attempts if <span markdown="span">`restart-strategy`</span>
has been set to <span markdown="span">`failure-rate`</span>. It can be specified
using notation: "1 min", "20 s"</td>
         </tr>
         <tr>
             <td><h5>restart-strategy.failure-rate.failure-rate-interval</h5></td>
-            <td style="word-wrap: break-word;">"1 min"</td>
-            <td>String</td>
+            <td style="word-wrap: break-word;">60000ms</td>
 
 Review comment:
   as a future note for the generator, if the value in milliseconds is a lot larger we may
want to display this in seconds/minutes instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message