flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wangxlong commented on issue #10144: [FLINK-14613][table-planner-blink] Fix temporal table join when containing multiple keyfields with UDF
Date Sun, 17 Nov 2019 09:39:28 GMT
wangxlong commented on issue #10144: [FLINK-14613][table-planner-blink] Fix temporal table
join when containing multiple keyfields with UDF
URL: https://github.com/apache/flink/pull/10144#issuecomment-554728811
 
 
   > Thanks @wangxlong .
   > 
   > Could you add some plan tests in `LookupJoinTest`? We can add some tests like :
   > 
   > 1. only equality condition with UDF ==> should fail
   > 2. UDF condition + constant condition
   > 3. UDF condition + field reference condition
   
   It is my pleasure. The first case already exists. So I add:
   1. one UDF condition + constant condition
   2. multi UDF condition + constant condition
   3. UDF condition + field reference condition
   Do you think we should add anything else?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message