flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StephanEwen commented on a change in pull request #10228: [FLINK-14816] Add thread dump feature for taskmanager
Date Tue, 19 Nov 2019 18:55:18 GMT
StephanEwen commented on a change in pull request #10228: [FLINK-14816] Add thread dump feature
for taskmanager
URL: https://github.com/apache/flink/pull/10228#discussion_r348107315
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ##########
 @@ -946,6 +948,19 @@ public void disconnectResourceManager(Exception cause) {
 	//  Internal methods
 	// ======================================================================
 
+	private CompletableFuture<TransientBlobKey> putTransientStream(InputStream inputStream,
FileType fileType) {
 
 Review comment:
   I would name this something like `putTransientBlobStream` to make clear that this is about
Blob storage. Otherwise it sounds very non-specific.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message