flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner
Date Thu, 21 Nov 2019 10:18:11 GMT
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support
precision of TimestampType in blink planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349000347
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/BuiltInMethods.scala
 ##########
 @@ -220,7 +218,7 @@ object BuiltInMethods {
   val TIMESTAMP_TO_STRING = Types.lookupMethod(
     classOf[SqlDateTimeUtils],
     "timestampToString",
-    classOf[Long], classOf[Int])
+    classOf[SqlTimestamp])
 
 Review comment:
   No. The old one would pad ‘0’ when the precision larger than number of digits of fractional
seconds. Now we follows a more standards-compliant style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message