flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner
Date Thu, 21 Nov 2019 11:37:20 GMT
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support
precision of TimestampType in blink planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349036445
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/SqlTimestamp.java
 ##########
 @@ -119,6 +119,25 @@ public static SqlTimestamp fromEpochMillis(long millisecond, int nanoOfMilliseco
 		return new SqlTimestamp(millisecond, nanoOfMillisecond);
 	}
 
+	/**
+	 * Obtains an instance of {@code SqlTimestamp} from a millisecond.
+	 *
+	 * <p>This returns a {@code SqlTimestamp} with the specified millisecond.
+	 * The nanoOfMillisecond field will be set to zero.
+	 *
+	 * @param millisecond the number of milliseconds since January 1, 1970, 00:00:00 GMT
+	 *                    A negative number is the number of milliseconds before
+	 *                    January 1, 1970, 00:00:00 GMT
+	 * @return an instance of {@code SqlTimestamp}
+	 */
+	public static SqlTimestamp fromEpochMillis(Long millisecond) {
 
 Review comment:
   It's useless now (providing for the original to_timestamp function). I will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message