flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
Date Fri, 22 Nov 2019 18:53:28 GMT
walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded
flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r348089251
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
 ##########
 @@ -263,6 +298,36 @@ private static LocalResource registerLocalResource(FileSystem fs, Path
remoteRsr
 		return localResource;
 	}
 
+	/**
+	 * Register a local resource with resource info. The resource info may contains multiple
parts.
+	 * For example, RemotePath;[resourceSize;resourceModificationTime;LocalResourceVisibility]
+	 * @param resourceInfoStr resource info string
+	 * @param yarnConfig yarn configuration
+	 * @return local resource tuple, f0 is filename, f1 is local resource.
+	 */
+	private static Tuple2<String, LocalResource> registerLocalResource(
 
 Review comment:
   I was under the similar assumption as @TisonKun previously that: this is supporting registering
`hdfs://...`. 
   so, since these are `private` internal methods, after some considerations I am fine with
the overload as long as the external facing ones are named correctly 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message