flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] rkhachatryan opened a new pull request #10326: [FLINK-12484][runtime] remove unnessecary checkpoint lock usages
Date Tue, 26 Nov 2019 14:49:40 GMT
rkhachatryan opened a new pull request #10326: [FLINK-12484][runtime] remove unnessecary checkpoint
lock usages
URL: https://github.com/apache/flink/pull/10326
 
 
   ## What is the purpose of the change
   
   * Push `getCheckpointLock()` method from `StreamTask` down to `StreamSourceTask` and use
`MailboxExecutor` instead (where possible).
   
   ## Brief change log
   
     - *introduce `ExecutionDecorator` field in `StreamTask` and `MailboxProcessor`; for `SourceStream`
task it synchronizes every action on a monitor, for any other task just executes it*
     - *migrate `ContinuousFileReader` to `MailboxExecutor`; at first, the most simple solution
to be checked (for performance degradation)*
     - *remove any remaining other `getCheckpointLock()` usages*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *'ContinuousFileProcessingMigrationTest',
'StreamTaskTest', 'ContinuousFileReader' benchmark*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): *no*
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: *no*
     - The serializers: *no*
     - The runtime per-record code paths (performance sensitive): *yes* (coarser lock granularity
for SourceStreamTask, ignoring priority of actions in 'ContinuousFileReader')
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: *yes* ('ContinuousFileReader' will no longer snapshot any state)
     - The S3 file system connector: *no*
   
   ## Documentation
   
     - Does this pull request introduce a new feature? *no*
     - If yes, how is the feature documented? *not applicable*
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message