flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] TisonKun commented on a change in pull request #10313: [FLINK-14840] Use Executor interface in SQL cli
Date Wed, 27 Nov 2019 01:54:02 GMT
TisonKun commented on a change in pull request #10313: [FLINK-14840] Use Executor interface
in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r351063385
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ProgramTargetDescriptor.java
 ##########
 @@ -25,56 +25,28 @@
  */
 public class ProgramTargetDescriptor {
 
-	private final String clusterId;
-
 	private final String jobId;
 
-	private final String webInterfaceUrl;
-
-	public ProgramTargetDescriptor(String clusterId, String jobId, String webInterfaceUrl) {
-		this.clusterId = clusterId;
+	public ProgramTargetDescriptor(String jobId) {
 		this.jobId = jobId;
-		this.webInterfaceUrl = webInterfaceUrl;
-	}
-
-	public String getClusterId() {
-		return clusterId;
 	}
 
 	public String getJobId() {
 
 Review comment:
   Make sense. Track as [FLINK-14958](https://issues.apache.org/jira/browse/FLINK-14958).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message