flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From João Boto (Jira) <j...@apache.org>
Subject [jira] [Commented] (FLINK-13850) Refactor part file configuration into a single method
Date Fri, 15 Nov 2019 16:52:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975242#comment-16975242
] 

João Boto commented on FLINK-13850:
-----------------------------------

[~chesnay], [~gyfora]  its fixed..

new pull request available [https://github.com/apache/flink/pull/10225]

 

 

> Refactor part file configuration into a single method
> -----------------------------------------------------
>
>                 Key: FLINK-13850
>                 URL: https://issues.apache.org/jira/browse/FLINK-13850
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / FileSystem
>            Reporter: Gyula Fora
>            Assignee: João Boto
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently there is only two methods on both format builders
> withPartFilePrefix and withPartFileSuffix for configuring the part files but in the
future it is likely to grow.
>  * More settings, different directories for pending / inprogress files etc
> I suggest we remove these two methods and replace them with a single : withPartFileConfig(..)
where we use an extensible config class.
> This should be fixed before 1.10 in order to not release the other methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message