flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Terry Wang (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-14801) flink sql parser unparser func partition frame local variable name mistake
Date Fri, 15 Nov 2019 13:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975114#comment-16975114
] 

Terry Wang commented on FLINK-14801:
------------------------------------

Right.

> flink sql parser unparser func  partition frame local variable name mistake
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-14801
>                 URL: https://issues.apache.org/jira/browse/FLINK-14801
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>    Affects Versions: 1.9.1
>            Reporter: xiaodao
>            Priority: Trivial
>             Fix For: 1.10.0
>
>
> in the class   org.apache.flink.sql.parser.ddl.SqlCreateTable#unparse
> {code:java}
> //代码占位符
> if (this.partitionKeyList != null && this.partitionKeyList.size() > 0) { 
>       writer.newlineAndIndent(); writer.keyword("PARTITIONED BY"); 
>       SqlWriter.Frame withFrame = writer.startList("(", ")");
>       this.partitionKeyList.unparse(writer, leftPrec, rightPrec); 
>       writer.endList(withFrame);
>       writer.newlineAndIndent();
>  }
> {code}
> it's better to modify name withFrame  to partitionedByFrame



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message