flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] link3280 commented on a change in pull request #7314: [FLINK-11135][YARN] Refactor Hadoop config loading in HadoopUtils
Date Tue, 07 Jan 2020 09:22:50 GMT
link3280 commented on a change in pull request #7314: [FLINK-11135][YARN] Refactor Hadoop config
loading in HadoopUtils
URL: https://github.com/apache/flink/pull/7314#discussion_r363656574
 
 

 ##########
 File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java
 ##########
 @@ -143,4 +142,24 @@ public static boolean isMinHadoopVersion(int major, int minor) throws
FlinkRunti
 
 		return maj > major || (maj == major && min >= minor);
 	}
+
+	/**
+	 * Search Hadoop configuration files in the given path, and add them to the configuration
if found.
+	 */
+	private static boolean addHadoopConfIfFound(Configuration configuration, String possibleHadoopConfPath)
{
+		boolean foundHadoopConfiguration = false;
 
 Review comment:
   Good point

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message