flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski commented on a change in pull request #10794: [FLINK-15490][kafka][test-stability] Enable idempotence producing in …
Date Wed, 08 Jan 2020 10:35:34 GMT
pnowojski commented on a change in pull request #10794: [FLINK-15490][kafka][test-stability]
Enable idempotence producing in …
URL: https://github.com/apache/flink/pull/10794#discussion_r364164729
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/DataGenerators.java
 ##########
 @@ -104,6 +104,8 @@ public void cancel() {
 		if (secureProps != null) {
 			props.putAll(testServer.getSecureProperties());
 		}
+		// Ensure the producer enables idempotence.
+		props.putAll(testServer.getIdempotentProducerConfig());
 
 Review comment:
   Is this the only place where we should be using `enable.idempotence`? 
   
   Do I remember correctly that `enable.idempotence` is automatically/effectively set to true
when using transactional kafka producer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message