flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] tillrohrmann commented on a change in pull request #10866: Enable TTL compaction filter by default and deprecate/remove some other TTL API
Date Thu, 16 Jan 2020 08:08:02 GMT
tillrohrmann commented on a change in pull request #10866: Enable TTL compaction filter by
default and deprecate/remove some other TTL API
URL: https://github.com/apache/flink/pull/10866#discussion_r367278057
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
 ##########
 @@ -59,10 +59,15 @@
 		.defaultValue(1)
 		.withDescription("The number of threads (per stateful operator) used to transfer (download
and upload) files in RocksDBStateBackend.");
 
-	/** This determines if compaction filter to cleanup state with TTL is enabled. */
+	/**
+	 * This determines if compaction filter to cleanup state with TTL is enabled.
+	 *
+	 * @deprecated the option will be removed in future and have no effect.
 
 Review comment:
   Good point. Will change it while merging the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message