flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #10894: [FLINK-15592][hive] Add black list for Hive built-in functions
Date Sun, 19 Jan 2020 21:25:09 GMT
bowenli86 commented on a change in pull request #10894: [FLINK-15592][hive] Add black list
for Hive built-in functions
URL: https://github.com/apache/flink/pull/10894#discussion_r368324020
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
 ##########
 @@ -47,6 +51,14 @@
  */
 public class HiveShimV120 extends HiveShimV111 {
 
+	// a set of functions that shouldn't be overridden by HiveModule
+	@VisibleForTesting
+	public static final Set<String> BUILT_IN_FUNC_BLACKLIST = Collections.unmodifiableSet(new
HashSet<>(
 
 Review comment:
   should this be in HiveModule rather than hive shim?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message