flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink-statefun] igalshilman commented on a change in pull request #3: [FLINK-15759][FLINK-15757][FLINK-15764] Adjust POM definitions
Date Wed, 29 Jan 2020 09:27:35 GMT
igalshilman commented on a change in pull request #3: [FLINK-15759][FLINK-15757][FLINK-15764]
Adjust POM definitions
URL: https://github.com/apache/flink-statefun/pull/3#discussion_r372271064
 
 

 ##########
 File path: statefun-examples/statefun-ridesharing-example/statefun-ridesharing-example-simulator/pom.xml
 ##########
 @@ -92,12 +102,6 @@ under the License.
             <version>28.0-jre</version>
         </dependency>
 
-        <dependency>
-            <groupId>org.projectlombok</groupId>
-            <artifactId>lombok</artifactId>
 
 Review comment:
   I agree that this is a bit messy, because removing Lombok also means replacing the classes
with a full blown value classes.
   I will separate these changes to two separate commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message