flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] twalthr commented on a change in pull request #10960: [FLINK-15487][table] Update code generation for new type inference
Date Fri, 31 Jan 2020 13:47:48 GMT
twalthr commented on a change in pull request #10960: [FLINK-15487][table] Update code generation
for new type inference
URL: https://github.com/apache/flink/pull/10960#discussion_r373486485
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
 ##########
 @@ -572,12 +572,15 @@ object GenerateUtils {
     * @param ctx code generator context which maintains various code statements.
     * @param fieldType type of field
     * @param fieldTerm expression term of field to be unboxed
+    * @param unboxingTerm unboxing/conversion term
     * @return internal unboxed field representation
     */
   def generateInputFieldUnboxing(
       ctx: CodeGeneratorContext,
       fieldType: LogicalType,
-      fieldTerm: String): GeneratedExpression = {
+      fieldTerm: String,
 
 Review comment:
   I think the method should be refactored in the future. In Flink planner, this method was
intended to perform `genToInternalIfNeeded`. Now the concepts are mixed up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message