flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink-statefun] tzulitai commented on a change in pull request #5: [FLINK-15769] [kafka-io] Add configuring startup position for Kafka ingress
Date Fri, 31 Jan 2020 14:29:21 GMT
tzulitai commented on a change in pull request #5: [FLINK-15769] [kafka-io] Add configuring
startup position for Kafka ingress
URL: https://github.com/apache/flink-statefun/pull/5#discussion_r373506543
 
 

 ##########
 File path: statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/KafkaSourceProvider.java
 ##########
 @@ -52,6 +52,8 @@
     Properties properties = new Properties();
     properties.putAll(spec.properties());
     properties.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, spec.kafkaAddress());
+    properties.put(
+        ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, spec.autoResetPosition().asKafkaConfig());
 
 Review comment:
   As discussed offline, I'll address this with a separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message