flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jark Wu (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (FLINK-15409) Fix code generation in windowed join function
Date Wed, 01 Jan 2020 02:33:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-15409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jark Wu resolved FLINK-15409.
-----------------------------
    Resolution: Fixed

1.11.0: e1340a006e3f76b71323dc87f61063fedfdc7f3b
1.10.0: d41f75ec749703b778c0e2f0cb56359667fa87cd

> Fix code generation in windowed join function
> ---------------------------------------------
>
>                 Key: FLINK-15409
>                 URL: https://issues.apache.org/jira/browse/FLINK-15409
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>            Reporter: hailong wang
>            Assignee: hailong wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In WindowJoinUtil#generateJoinFunction, When otherCondition is none, it will go into 
statement:
> {code:java}
> case None =>
>   s"""
>      |$buildJoinedRow
>      |$collectorTerm.collect($joinedRow)
>      |""".stripMargin
> {code}
> And it miss a semicolon after collet($joinedRow). This will cause compile fail:
> {code:java}
> Caused by: org.apache.flink.api.common.InvalidProgramException: Table program cannot
be compiled. This is a bug. Please file an issue.Caused by: org.apache.flink.api.common.InvalidProgramException:
Table program cannot be compiled. This is a bug. Please file an issue. at org.apache.flink.table.runtime.generated.CompileUtils.doCompile(CompileUtils.java:81)
at org.apache.flink.table.runtime.generated.CompileUtils.compile(CompileUtils.java:65) at
org.apache.flink.table.runtime.generated.GeneratedClass.compile(GeneratedClass.java:78) at
org.apache.flink.table.runtime.generated.GeneratedClass.newInstance(GeneratedClass.java:52)
... 26 moreCaused by: org.codehaus.commons.compiler.CompileException: Line 28, Column 21:
Expression "c.collect(joinedRow)" is not a type
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message