flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingsong Lee (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLINK-15595) Resolution Order is chaotic not as FLIP-68 defined
Date Thu, 16 Jan 2020 09:50:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-15595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016763#comment-17016763
] 

Jingsong Lee edited comment on FLINK-15595 at 1/16/20 9:49 AM:
---------------------------------------------------------------

Thanks [~twalthr] and [~dwysakowicz] for involving.

Yes, I think for a long time, it's hard to come up with a reliable simple solution. So I
am + 1 for add a warning and documentation. Since it is really a surprise to users and even
developers.

But if we can not solve this, then FLINK-15592 is a blocker. Because I think over window
not work when open hive built-in functions, then the ingesting Hive built-in functions not
works. There are some disruptive functions in hive built-in functions, we should exclude them.


was (Author: lzljs3620320):
Thanks [~twalthr] for involving.

Yes, I think for a long time, it's hard to come up with a reliable simple solution. So I
am + 1 for add a warning and documentation.

But if we can not solve this, then FLINK-15592 is a blocker. Because I think over window
not work when open hive built-in functions, then the ingesting Hive built-in functions not
works. There are some disruptive functions in hive built-in functions, we should exclude them.

> Resolution Order is chaotic not as FLIP-68 defined
> ---------------------------------------------------
>
>                 Key: FLINK-15595
>                 URL: https://issues.apache.org/jira/browse/FLINK-15595
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>            Reporter: Jingsong Lee
>            Priority: Critical
>             Fix For: 1.10.0
>
>
> First of all, the implementation is problematic. CoreModule returns BuiltinFunctionDefinition,
which cannot be resolved in FunctionCatalogOperatorTable, so it will fall back to FlinkSqlOperatorTable.
> Second, the function defined by CoreModule is seriously incomplete. You can compare it
with FunctionCatalogOperatorTable, a lot less. This leads to the fact that the priority
of some functions is in CoreModule, and the priority of some functions is behind all modules.
This is confusing, which is not what we want to define in FLIP-68. 
> We should:
>  * We should resolve BuiltinFunctionDefinition correctly in FunctionCatalogOperatorTable.
>  * CoreModule should contains all functions in FlinkSqlOperatorTable, a simple way could
provided calcite wrapper to wrap all functions.
>  * PlannerContext.getBuiltinSqlOperatorTable should not contains FlinkSqlOperatorTable,
we should use one FunctionCatalogOperatorTable.Otherwise, there will be a lot of confusion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message