flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingsong Lee (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-15595) Entirely implement resolution order as FLIP-68 concept
Date Thu, 16 Jan 2020 09:59:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-15595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016773#comment-17016773

Jingsong Lee commented on FLINK-15595:

[~twalthr] [~dwysakowicz] BTW, another thing is that {{FunctionCatalogOperatorTable}} can
not solve {{BuiltInFunctionDefinition}}. This is wrong. Looks very weird, and some functions
in {{BuiltInFunctionDefinitions}} like {{GET}} can never be solved, and user can not define
it in catalog too.

> Entirely implement resolution order as FLIP-68 concept
> ------------------------------------------------------
>                 Key: FLINK-15595
>                 URL: https://issues.apache.org/jira/browse/FLINK-15595
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>            Reporter: Jingsong Lee
>            Priority: Critical
>             Fix For: 1.10.0
> First of all, the implementation is problematic. CoreModule returns BuiltinFunctionDefinition,
which cannot be resolved in FunctionCatalogOperatorTable, so it will fall back to FlinkSqlOperatorTable.
> Second, the function defined by CoreModule is seriously incomplete. You can compare it
with FunctionCatalogOperatorTable, a lot less. This leads to the fact that the priority
of some functions is in CoreModule, and the priority of some functions is behind all modules.
This is confusing, which is not what we want to define in FLIP-68. 
> We should:
>  * We should resolve BuiltinFunctionDefinition correctly in FunctionCatalogOperatorTable.
>  * CoreModule should contains all functions in FlinkSqlOperatorTable, a simple way could
provided calcite wrapper to wrap all functions.
>  * PlannerContext.getBuiltinSqlOperatorTable should not contains FlinkSqlOperatorTable,
we should use one FunctionCatalogOperatorTable.Otherwise, there will be a lot of confusion.

This message was sent by Atlassian Jira

View raw message