flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] gaoyunhaii opened a new pull request #10736: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
Date Wed, 01 Jan 2020 15:45:16 GMT
gaoyunhaii opened a new pull request #10736: [FLINK-15010][Network] Add shutdown hook to ensure
cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/10736
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help
us improve Flink. To help the community review your contribution in the best possible way,
please go through the checklist below, which will get the contribution into a shape in which
it can be best reviewed.*
   *Please understand that we do not do this to make contributions to Flink a hassle. In order
to uphold a high standard of quality for code contributions, while at the same time managing
a large number of contributions, we need contributors to prepare the contributions well, and
give reviewers enough contextual information for the review. Please also understand that contributions
that do not follow this guide will take longer to review and thus typically be picked up with
lower priority by the community.*
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request",
where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you
are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern:
`[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc
for PuncuatedWatermarkGenerator`.
     - Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
     - Each pull request should address only one issue, not mix up code from multiple issues.
     - Each commit in the pull request has a meaningful commit message (including the JIRA
     - Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
   **(The sections below can be removed for hotfixes of typos)**
   ## What is the purpose of the change
   When shutting down the cluster in standalone mode, the task manager is shutdown by emit
SIG_TERM signal. In this case, the directories are cleaned up by the shutdown hooks. However,
`NettyShuffleEnvironment` does not register shutdown hook normally, which causes the `flink-netty-shuffle-*`
directories not  cleaned finally.
   To fix this issue, we registered the corresponding shutdown hooks. To ensure the directories
could be removed, the hook must be registered before creating the directories. Therefore,
it is not suitable to register shutdown hook in `NettyShuffleEnvironment`. Instead, we chose
to allow users to register shutdown hook for each `FileChannelManagerImpl`.   
   ## Brief change log
   - 1a6b51a57cbf23b054b3b20dd5dbb30a03b561ef registered shutdown hook for `FileChannelManagerImpl`
used in `NettyShuffleEnvironment`. 
   ## Verifying this change
   This change added tests and can be verified as follows:
     - Added test that validates that `flink-netty-shuffle-*` get cleared after task manager
received SIG_TERM signals. 
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   ## Documentation
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message