flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lirui-apache commented on a change in pull request #12419: [FLINK-17996][table-planner-blink] NPE in CatalogTableStatisticsConverter.convertToColumnStats method
Date Mon, 01 Jun 2020 03:22:57 GMT

lirui-apache commented on a change in pull request #12419:
URL: https://github.com/apache/flink/pull/12419#discussion_r433026393



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/CatalogTableStatisticsConverter.java
##########
@@ -61,12 +61,14 @@ public static TableStats convertToTableStats(
 		return new TableStats(rowCount, columnStatsMap);
 	}
 
-	private static Map<String, ColumnStats> convertToColumnStatsMap(
+	public static Map<String, ColumnStats> convertToColumnStatsMap(

Review comment:
       Add VisibleForTesting annotation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message