flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dianfu commented on a change in pull request #12422: [FLINK-17901][python] Add module interface in PyFlink
Date Wed, 03 Jun 2020 03:59:01 GMT

dianfu commented on a change in pull request #12422:
URL: https://github.com/apache/flink/pull/12422#discussion_r434294304



##########
File path: flink-python/pyflink/table/module.py
##########
@@ -0,0 +1,45 @@
+################################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+from pyflink.java_gateway import get_gateway
+
+__all__ = ['Module', 'HiveModule']
+
+
+class Module(object):
+    """
+    Modules define a set of metadata, including functions, user defined types, operators,
rules,
+    etc.
+    Metadata from modules are regarded as built-in or system metadata that users can take
advantages
+    of.
+    """
+
+    def __init__(self, j_module):
+        self._j_module = j_module
+
+
+class HiveModule(Module):
+    """
+    Module to provide Hive built-in metadata.
+    """
+
+    def __init__(self, j_hive_module=None):
+        gateway = get_gateway()
+
+        if j_hive_module is None:

Review comment:
       it seems that the parameter `j_hive_module` is not necessary. I noticed that there
is such a parameter in HiveCatalog, however I guess we should also remove it. What do you
think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message