flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingsong Lee (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box
Date Fri, 05 Jun 2020 04:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126378#comment-17126378

Jingsong Lee commented on FLINK-16497:

+1 to default flush size (100) and flush interval(1s). 

I think we should find a trade-off between initial experience and production.

I think 1s is good enough for user experience out-of-box. And these default values can also
work for production.

IIUC, elasticsearch also has a good default flush values for both user experience out-of-box
and production.

> Improve default flush strategy for JDBC sink to make it work out-of-box
> -----------------------------------------------------------------------
>                 Key: FLINK-16497
>                 URL: https://issues.apache.org/jira/browse/FLINK-16497
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / JDBC, Table SQL / Ecosystem
>            Reporter: Jark Wu
>            Priority: Critical
>             Fix For: 1.11.0
> Currently, JDBC sink provides 2 flush options:
> {code}
> 'connector.write.flush.max-rows' = '5000', -- default is 5000
> 'connector.write.flush.interval' = '2s', -- no default value
> {code}
> That means if flush interval is not set, the buffered output rows may not be flushed
to database for a long time. That is a surprising behavior because no results are outputed
by default. 
> So I propose to have a default flush '1s' interval for JDBC sink or default 1 row for
flush size. 

This message was sent by Atlassian Jira

View raw message