fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] incubator-fluo pull request #760: Fixes #758
Date Fri, 12 Aug 2016 15:02:14 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/760#discussion_r74605858
  
    --- Diff: modules/core/src/main/java/org/apache/fluo/core/impl/TransactionImpl.java ---
    @@ -190,6 +190,8 @@ public Bytes get(Bytes row, Column column) {
         return ret;
       }
     
    +  // TODO: Fix override to return Map<RowColumn, Bytes>
    +  // TODO: Fix span() as this will move to unsupported type.
    --- End diff --
    
    Could create a new `HashMap<RowColumn, Bytes>` and loop over what pss.scan() returned
adding to the new hash map.   Could add an inner loop to exisitng loop.... like the following.
    
    ```java
    //create HashMap<RowColumn, Bytes>
    
    for (Entry<Bytes, Map<Column, Bytes>> entry : ret.entrySet()) {
       updateColumnsRead(entry.getKey(), entry.getValue().keySet());
       for (Entry<Column, Bytes> cols : entry.getValue().entrySet()) {
        //create RowColumn  and add to new map
       }    
    }
    
    //return new map
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message