fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] incubator-fluo pull request #766: Avoid use of auxiliary class, and other wa...
Date Wed, 14 Sep 2016 17:44:34 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/766#discussion_r78798311
  
    --- Diff: modules/core/src/main/java/org/apache/fluo/core/thrift/OracleService.java ---
    @@ -26,6 +26,7 @@
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +@SuppressWarnings({"rawtypes", "unused", "serial", "unchecked"})
    --- End diff --
    
    The change is not fixing a bug or changing behavior, so regenerating and losing this change
should not introduce any bugs.  Based on this I think its ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message