fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] incubator-fluo-recipes pull request #112: Avoid allocating collection in Acc...
Date Thu, 13 Oct 2016 19:09:12 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo-recipes/pull/112#discussion_r83289440
  
    --- Diff: modules/accumulo/src/main/java/org/apache/fluo/recipes/accumulo/export/AccumuloExporter.java
---
    @@ -99,8 +101,8 @@ protected void processExports(Iterator<SequencedExport<K, V>>
exports) {
        * @param newData Map containing new row/column data
        * @param seq Export sequence number
        */
    -  public static Collection<Mutation> generateMutations(long seq, Map<RowColumn,
Bytes> oldData,
    -      Map<RowColumn, Bytes> newData) {
    +  public static void generateMutations(long seq, Map<RowColumn, Bytes> oldData,
    --- End diff --
    
    Could update javadoc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message