fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] incubator-fluo pull request #804: Added some caching of string to bytes conv...
Date Thu, 17 Nov 2016 19:19:12 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/804#discussion_r88521218
  
    --- Diff: modules/core/src/main/java/org/apache/fluo/core/util/ColumnUtil.java ---
    @@ -115,4 +115,12 @@ public static Column readColumn(DataInputStream in) throws IOException
{
         Bytes visibility = ByteUtil.read(bb, in);
         return new Column(family, qualifier, visibility);
       }
    +
    +  // TODO move
    --- End diff --
    
    Could create an issue rather than leave a TODO


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message