fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] incubator-fluo-website pull request #44: Update excercise 1 to add CFM and i...
Date Tue, 29 Nov 2016 21:06:14 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo-website/pull/44#discussion_r90113456
  
    --- Diff: tour/exercise-1.md ---
    @@ -240,14 +237,15 @@ public class ContentObserver extends AbstractObserver {
       /**
        * Utility method to tokenize the content of a document into unique words.
        */
    -  private Set<String> tokenize(String content) {
    -    return new HashSet<String>(Arrays.asList(content.split("[ .!,]+")));
    +  private String[] tokenize(String content) {
    --- End diff --
    
    Personally, I would keep the `Set<String>` return type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message