fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...
Date Wed, 22 Mar 2017 16:46:31 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/817#discussion_r107467565
  
    --- Diff: modules/integration/src/test/java/org/apache/fluo/integration/impl/FailureIT.java
---
    @@ -54,29 +52,29 @@
     import org.junit.Test;
     import org.junit.rules.ExpectedException;
     
    +import static org.apache.fluo.api.observer.Observer.NotificationType.STRONG;
     import static org.apache.fluo.integration.BankUtil.BALANCE;
     
     public class FailureIT extends ITBaseImpl {
     
       @Rule
       public ExpectedException exception = ExpectedException.none();
     
    -  public static class NullObserver extends AbstractObserver {
    -
    +  public static class NullObserver implements Observer {
         @Override
         public void process(TransactionBase tx, Bytes row, Column col) throws Exception {}
    +  }
     
    +  public static class FailuresObserverProvider implements ObserverProvider {
         @Override
    -    public ObservedColumn getObservedColumn() {
    -      return new ObservedColumn(new Column("attr", "lastupdate"), NotificationType.STRONG);
    +    public void provide(Registry consumer, Context ctx) {
    --- End diff --
    
    Replace `consumer` with `registry`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message